diff --git a/eth-simple-shortlinks.php b/eth-simple-shortlinks.php index 128b32e06fa0ba7bf7ab4361bd8bedb4b0af53b7..51817c18cb99ae9b55cf3eb5a298bab47fe18248 100644 --- a/eth-simple-shortlinks.php +++ b/eth-simple-shortlinks.php @@ -134,11 +134,11 @@ class ETH_Simple_Shortlinks { return $shortlink; } - if ( ! in_array( get_post_status( $id ), $this->supported_post_statuses ) ) { + if ( ! $this->is_supported_post_status( get_post_status( $id ) ) ) { return $shortlink; } - if ( ! in_array( get_post_type( $id ), $this->supported_post_types ) ) { + if ( ! $this->is_supported_post_type( get_post_type( $id ) ) ) { return $shortlink; } @@ -150,7 +150,7 @@ class ETH_Simple_Shortlinks { */ public function add_admin_header_assets() { global $typenow; - if ( ! in_array( $typenow, $this->supported_post_types ) ) { + if ( ! $this->is_supported_post_type( $typenow ) ) { return; } @@ -172,7 +172,7 @@ class ETH_Simple_Shortlinks { * Provide the shortlink in row actions for easy access */ public function filter_row_actions( $actions, $post ) { - if ( ! in_array( get_post_type( $post ), $this->supported_post_types ) || ! in_array( get_post_status( $post ), $this->supported_post_statuses ) ) { + if ( ! $this->is_supported_post_type( get_post_type( $post ) ) || ! $this->is_supported_post_status( get_post_status( $post ) ) ) { return $actions; } @@ -181,6 +181,20 @@ class ETH_Simple_Shortlinks { return $actions; } + /** + * Check if given post type is supported + */ + private function is_supported_post_type( $type ) { + return in_array( $type, $this->supported_post_types ); + } + + /** + * Check if given post status is supported + */ + private function is_supported_post_status( $status ) { + return in_array( $status, $this->supported_post_statuses ); + } + /** * Utility method for building permlink */