From a15a433d77677d1df0a106fcbc91e15854ce6377 Mon Sep 17 00:00:00 2001
From: Erick Hitter <git-contrib@ethitter.com>
Date: Thu, 7 Sep 2017 18:23:04 -0700
Subject: [PATCH] Note more TODOs
---
includes/functions.php | 2 ++
includes/run.php | 1 +
2 files changed, 3 insertions(+)
diff --git a/includes/functions.php b/includes/functions.php
index 7a3fce4..8ea93c8 100644
--- a/includes/functions.php
+++ b/includes/functions.php
@@ -18,6 +18,7 @@ function is_command_allowed( $command ) {
* @return array
*/
function get_command_whitelist() {
+ // TODO: constant!
// Supported built-in commands
$whitelist = array(
'cache',
@@ -54,6 +55,7 @@ function get_command_whitelist() {
* @return array
*/
function get_command_blacklist() {
+ // TODO: constant!
return array(
'cli',
'config',
diff --git a/includes/run.php b/includes/run.php
index 4377f8d..f49859e 100644
--- a/includes/run.php
+++ b/includes/run.php
@@ -32,6 +32,7 @@ function run_event( $command ) {
// Command failed
if ( ! is_object( $output ) || is_wp_error( $output ) ) {
+ // TODO: message consistency, revisit using ACTION as the "key", seems wrong
trigger_error( 'WP-CLI command failed. (' . var_export( $command, true ) . ')', E_USER_WARNING );
trigger_error( var_export( $output, true ), E_USER_WARNING );
return;
--
GitLab