Commit 453b81f0 authored by Erick Hitter's avatar Erick Hitter
Browse files

Merge branch 'add/unit-tests' into 'master'

Introduce unit tests

See merge request !3
parents 920a3ca6 7652c793
Pipeline #880 passed with stages
in 2 minutes and 11 seconds
......@@ -88,7 +88,7 @@ PHP7.3:
PluginSVN:
stage: deploy
image: containers.ethitter.com:443/docker/images/php:7.3
image: containers.ethitter.com:443/docker/wp-org-plugin-deploy:latest
before_script:
- curl -o ./bin/deploy.sh https://git-cdn.e15r.co/open-source/wp-org-plugin-deploy/raw/master/scripts/deploy.sh
- chmod +x ./bin/deploy.sh
......
......@@ -230,21 +230,43 @@ class external_permalinks_redux {
return;
}
$link = get_post_meta( $post->ID, $this->meta_key_target, true );
$redirect = $this->get_redirect_data( $post->ID );
if ( ! empty( $link ) ) {
$type = (int) get_post_meta( $post->ID, $this->meta_key_type, true );
$type = apply_filters( 'epr_status_code', $type, $link, $post );
if ( false === $redirect ) {
return;
}
if ( ! $type ) {
$type = 302;
}
// Unreasonable to validate redirect destination.
// phpcs:ignore WordPress.Security.SafeRedirect.wp_redirect_wp_redirect
wp_redirect( $redirect['link'], $redirect['type'] );
exit;
}
// Unreasonable to validate redirect destination.
// phpcs:ignore WordPress.Security.SafeRedirect.wp_redirect_wp_redirect
wp_redirect( $link, $type );
exit;
/**
* Retrieve redirect data for a given post ID.
*
* @param int $post_id Post ID.
* @return array|bool
*/
public function get_redirect_data( $post_id ) {
if ( ! is_numeric( $post_id ) ) {
return false;
}
$link = get_post_meta( $post_id, $this->meta_key_target, true );
if ( empty( $link ) ) {
return false;
}
$type = (int) get_post_meta( $post_id, $this->meta_key_type, true );
$type = apply_filters( 'epr_status_code', $type, $link, get_post( $post_id ) );
if ( ! $type ) {
$type = 302;
}
return compact( 'link', 'type' );
}
}
......
<?php
/**
* Class AdminCallbacks
*
* @package External_Permalinks_Redux
*/
/**
* Test admin callbacks
*/
class AdminCallbacks extends WP_UnitTestCase {
/**
* Redirect destination.
*/
const DESTINATION = 'https://w.org/';
/**
* Redirect type.
*/
const TYPE = 302;
/**
* Test post ID.
*
* @var int
*/
protected $post_id;
/**
* Plugin instance.
*
* @var external_permalinks_redux
*/
protected $plugin;
/**
* Metabox nonce.
*
* @var string
*/
protected $nonce;
/**
* Create some objects with redirects.
*/
public function setUp() {
parent::setUp();
$this->plugin = external_permalinks_redux::get_instance();
$this->post_id = $this->factory->post->create(
[
'post_type' => 'post',
]
);
$this->nonce = wp_create_nonce( 'external-permalinks-redux' );
}
/**
* Test metabox rendering.
*/
public function test_meta_box() {
ob_start();
$this->plugin->meta_box( get_post( $this->post_id ) );
$meta_box_contents = ob_get_clean();
$this->assertContains( 'value="' . $this->nonce . '"', $meta_box_contents );
foreach ( array_keys( $this->plugin->status_codes ) as $code ) {
$this->assertContains( 'value="' . $code . '"', $meta_box_contents );
}
}
/**
* Test metabox save.
*/
public function test_save_callback() {
$_POST[ $this->plugin->meta_key_target . '_nonce' ] = $this->nonce;
$_POST[ $this->plugin->meta_key_target . '_url' ] = static::DESTINATION;
$_POST[ $this->plugin->meta_key_target . '_type' ] = static::TYPE;
$this->plugin->action_save_post( $this->post_id );
$this->assertEquals( static::DESTINATION, get_post_meta( $this->post_id, $this->plugin->meta_key_target, true ) );
$this->assertEquals( static::TYPE, get_post_meta( $this->post_id, $this->plugin->meta_key_type, true ) );
}
}
<?php
/**
* Class PermalinkFilters
*
* @package External_Permalinks_Redux
*/
/**
* Test permalink filters
*/
class PermalinkFilters extends WP_UnitTestCase {
/**
* Redirect destination.
*/
const DESTINATION = 'https://w.org/';
/**
* Test post ID.
*
* @var int
*/
protected $post_id;
/**
* Test page ID.
*
* @var int
*/
protected $page_id;
/**
* Create some objects with redirects.
*/
public function setUp() {
parent::setUp();
$plugin = external_permalinks_redux::get_instance();
$this->post_id = $this->factory->post->create(
[
'post_type' => 'post',
]
);
update_post_meta( $this->post_id, $plugin->meta_key_target, static::DESTINATION );
$this->page_id = $this->factory->post->create(
[
'post_type' => 'page',
]
);
update_post_meta( $this->page_id, $plugin->meta_key_target, static::DESTINATION );
}
/**
* Test post permalink filter.
*/
public function test_post() {
$this->assertEquals( static::DESTINATION, get_permalink( $this->post_id ) );
}
/**
* Test page link filter.
*/
public function test_page() {
$this->assertEquals( static::DESTINATION, get_page_link( $this->page_id ) );
}
}
<?php
/**
* Class RedirectCallbacks
*
* @package External_Permalinks_Redux
*/
/**
* Test redirect callbacks
*/
class RedirectCallbacks extends WP_UnitTestCase {
/**
* Redirect destination.
*/
const DESTINATION = 'https://w.org/';
/**
* Plugin instance.
*
* @var external_permalinks_redux
*/
protected $plugin;
/**
* Create some objects with redirects.
*/
public function setUp() {
parent::setUp();
$this->plugin = external_permalinks_redux::get_instance();
}
/**
* Helper to retrieve a clean post.
*
* @return int
*/
protected function get_new_post() {
return $this->factory->post->create(
[
'post_type' => 'post',
]
);
}
/**
* Test post with default redirect code.
*/
public function test_post_redirect_default_status() {
$post_id = $this->get_new_post();
update_post_meta( $post_id, $this->plugin->meta_key_target, static::DESTINATION );
$redirect = $this->plugin->get_redirect_data( $post_id );
$this->assertEquals( static::DESTINATION, $redirect['link'] );
$this->assertEquals( 302, $redirect['type'] );
}
/**
* test post with custom redirect code.
*/
public function test_post_redirect_custom_status() {
$post_id = $this->get_new_post();
update_post_meta( $post_id, $this->plugin->meta_key_target, static::DESTINATION );
update_post_meta( $post_id, $this->plugin->meta_key_type, 307 );
$redirect = $this->plugin->get_redirect_data( $post_id );
$this->assertEquals( static::DESTINATION, $redirect['link'] );
$this->assertEquals( 307, $redirect['type'] );
}
/**
* Test post with redirect type but no destination.
*/
public function test_post_redirect_missing_destination() {
$post_id = $this->get_new_post();
update_post_meta( $post_id, $this->plugin->meta_key_type, 307 );
$redirect = $this->plugin->get_redirect_data( $post_id );
$this->assertFalse( $redirect );
}
/**
* Test post without redirect.
*/
public function test_post_no_redirect() {
$post_id = $this->get_new_post();
$redirect = $this->plugin->get_redirect_data( $post_id );
$this->assertFalse( $redirect );
}
}
<?php
/**
* Class SampleTest
*
* @package External_Permalinks_Redux
*/
/**
* Sample test case.
*/
class SampleTest extends WP_UnitTestCase {
/**
* A single example test.
*/
public function test_sample() {
// Replace this with some actual testing code.
$this->assertTrue( true );
}
}
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment