Skip to content
Snippets Groups Projects

Fix fatal in test run under PHP 8

Merged Erick Hitter requested to merge fix/test into master
1 file
+ 12
3
Compare changes
  • Side-by-side
  • Inline
  • 19660d31
    Fix fatal in test run under PHP 8 · 19660d31
    Erick Hitter authored
    ```
    Fatal error: Declaration of PostFilters::setUp() must be compatible with Yoast\PHPUnitPolyfills\TestCases\TestCase::setUp(): void in /builds/wp-plugins/view-all-posts-pages/tests/test-post-filters.php on line 40
    ```
@@ -36,10 +36,11 @@ class PostFilters extends WP_UnitTestCase {
/**
* Prepare data for tests.
*
* Not using `setUp` because Yoast polyfills add a return type for PHP 8
* that isn't supported before PHP 7.1.
*/
protected function setUp() {
parent::setUp();
protected function _create_post() {
static::$post_id = $this->factory->post->create(
array(
'post_title' => 'Pagination Test',
@@ -54,6 +55,8 @@ class PostFilters extends WP_UnitTestCase {
* Test retrieving page 1 content.
*/
public function test_view_page_1() {
$this->_create_post();
query_posts(
array(
'p' => static::$post_id,
@@ -73,6 +76,8 @@ class PostFilters extends WP_UnitTestCase {
* Test retrieving page 2 content.
*/
public function test_view_page_2() {
$this->_create_post();
query_posts(
array(
'p' => static::$post_id,
@@ -93,6 +98,8 @@ class PostFilters extends WP_UnitTestCase {
* Test retrieving page 3 content.
*/
public function test_view_page_3() {
$this->_create_post();
query_posts(
array(
'p' => static::$post_id,
@@ -113,6 +120,8 @@ class PostFilters extends WP_UnitTestCase {
* Test retrieving "view all" contents.
*/
public function test_view_all() {
$this->_create_post();
query_posts(
array(
'p' => static::$post_id,
Loading